Rated 5 out of 5 stars

by Hiromacu on Aug. 28, 2013 ·

Hi!

Good stuff, I like it (5 stars)! But...

I use Hungarian keyboard and when I want to write @ mark, what is AltGr+V (AltGr is the right Alt button in Hungarian keyboard) the website toggles private state of current tab instead of type that @ mark. So I changed the shortcut in your mod:

New private tab: Ctr+Alt+O
Toggle private state of current tab: Ctr+Alt+P

Now everything is fine. No other collision with keyboard layout. I just wanted let you know about this keyboard layout problem. Maybe you should change the official shortcuts.

Thanks!

This review is for a previous version of the add-on (0.1.3.1-signed). 

by Infocatcher (Developer) on Aug. 28, 2013 ·

I know about keyboard issue: http://forums.mozillazine.org/viewtopic.php?p=12816959#p12816959

> Maybe you should change the official shortcuts.
Yes, may be. I'll think about this.
But I think it's better to leave Ctr+Alt+P assigned to "open new private tab" feature, just like built-in Ctrl+Shift+P to open new private window. And use something like Ctrl+Alt+T (Toggle and about Tab) to toggle private state of current tab (or probably Ctrl+Alt+R, like pRivate). Is this good with your keyboard layout?